Check for subnet changes and redeclare network if True#27
Open
velis74 wants to merge 3 commits intostackhpc:masterfrom
Open
Check for subnet changes and redeclare network if True#27velis74 wants to merge 3 commits intostackhpc:masterfrom
velis74 wants to merge 3 commits intostackhpc:masterfrom
Conversation
Author
|
Eh, the beauty checks fail: could you please review & comment the code as-is before I check them? |
Author
|
Apologies for another commit: I'm very new to ansible and didn't realise that it used my local plugin instead of the role's one (which wasn't updated) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposal enhancement for #25
I had to create a filter to convert from get_xml's XML format into dict. facts and info did not return complete network info and were thus not useful.
Please forgive the when statements. I have no idea whether I could have done them nicer. The principal issue with them is of course fail-safe reading of possibly missing items from dict.
Edit: referenced the wrong issue, sorry.